vendor: bump Pebble to 59007c613a66 #71405
Conversation
|
This change is |
There was a problem hiding this comment.
ecc685b2 db: expose facility for retrieving batch count
Heads up that I think this commit will require a code change in some (one?) places in pkg/storage. pebble.NewBatchReader now returns another return value.
Reviewable status:
complete! 0 of 0 LGTMs obtained
There was a problem hiding this comment.
Ah yep. Just caught it. Thanks!
Reviewable status:
``` 59007c61 sstable: consolidate checksum types 17635b0a *: address staticcheck lints 11823273 *: address staticcheck lint check U1000 807abfe8 *: address staticcheck lint check S1039 d24dd342 all: remove some unused code 3bdca93a sstable: clarify comment on checksum input 926d23e9 pebble: remove comment related to batching from the table cache 0a6177ae db: tweak ErrClosed documentation ecc685b2 db: expose facility for retrieving batch count b2eb88a7 sstable: remove unused rawBlockIter err field ``` Adds a explicit size-check to error on uint -> int overflow. Release note: None.
nicktrav
force-pushed
the
nickt/pebble-master-59007c613a66
branch
from
6729eaf
to
8bb62b2
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/storage/batch.go, line 127 at r2 (raw file):
} r, c := pebble.ReadBatch(repr) if c > math.MaxInt32 {
@jbowens - looks like we were just casting before, so I added a check. Not sure if it's possible in practice to overflow, and can remove if obsolete.
|
bors r=jbowens |
|
Build succeeded: |
|
TFTR! |
Release note: None.